Thursday, February 09, 2012
Google Custom Search

ClearCanvas Highlights

Download our Open Source software
Watch some Videos
Get the Source
Check out our Licensing
Join our  Forums
Some Research: OICR IPP-Trials

Our Community

Membership Membership:
Latest New User Latest: tchlee
New Today New Today: 16
New Yesterday New Yesterday: 26
User Count Overall: 20579

People Online People Online:
Visitors Visitors: 11
Members Members: 2
Total Total: 13

Online Now Online Now:
01: Leighann
02: tchlee

ClearCanvas Community Forums

ApplicationComponentContainer hosting patch
Last Post 2009-05-04 12:32 PM by resnickj. 3 Replies.
Printer Friendly
Sort:
PrevPrev NextNext
You are not authorized to post a reply.
Author Messages
dreich
Basic Member
Basic Member
Posts:13

--
2009-04-24 10:22 AM  

Hi.  I'm submitting the patch for this work in the proper place.  Sorry for spamming the other forum - still learning the ropes.

I don't know if there is a ticket for this yet.

Thanks

Dave


Attachment: 002_001_ApplicationComponentContainerHosting.patch
Attachment: MoreAppCompContainerHosting.patch

dreich
Basic Member
Basic Member
Posts:13

--
2009-04-24 11:07 AM  

I messed up w.r.t submitting patches.  I had read about signing the CLA a while ago, but in my enthusiam, I forgot to get it taken care of officially here at work.  I've set the wheels in motion, but it might take awhile.  I'm really sorry I messed up the process.  Please handle my posts as you see fit.  Unofficially, I have not given away any proprietary stuff, but I still need to ask for forgiveness since I forgot to ask for permission.

Thanks

Dave



norman
Senior Member
Senior Member
Posts:811

--
2009-04-24 11:10 AM  
No worries Dave. Just submit the CLA at your earliest convenience.

N.


resnickj
Senior Member
Senior Member
Posts:968

--
2009-05-04 12:32 PM  

Hi Dave-

Just letting you know that we reviewed and integrated portions of the patch you submitted, under the following ticket:

https://trac.clearcanvas.ca/source/ticket/4413

Ultimately we came to the conclusion that having the CommandHistory property delegate up to the parent host was not an appropriate solution across the board, because the user experience of sharing a command history between pages of a container that supports pages (tab, navigator, etc) may not be acceptable.  Therefore this solution was adopted only for the SplitComponentContainer and SimpleComponentContainer.

Otherwise, the patch looked good from a quality/coding style point of view.  The only significant change I made was to rename the SubHost class to ContainedComponentHost, and make it protected rather than public.

Thanks again for the contribution.

j



Real-time support available to Clinical Edition and Team Edition customers
You are not authorized to post a reply.

Active Forums 4.1
Copyright 2011 ClearCanvas Inc.