Thursday, May 17, 2012
Google Custom Search

ClearCanvas Highlights

Download our Open Source software
Watch some Videos
Get the Source
Check out our Licensing
Join our  Forums
Some Research: OICR IPP-Trials

Our Community

Membership Membership:
Latest New User Latest: JBauza
New Today New Today: 19
New Yesterday New Yesterday: 33
User Count Overall: 22559

People Online People Online:
Visitors Visitors: 12
Members Members: 0
Total Total: 12

Online Now Online Now:

ClearCanvas Community Forums

Ticket #1217 (and more) implemented
Last Post 2007-11-29 06:05 PM by steve. 1 Replies.
Printer Friendly
Sort:
PrevPrev NextNext
You are not authorized to post a reply.
Author Messages
dblanchard
Senior Member
Senior Member
Posts:185

--
2007-11-23 04:29 PM  
Attached is a patch for the DicomDirectoryWriter as discussed here (thanks to Steve for all his guidance and help):

http://clearcanvas.easycgi.com/dnn/Community/Forums/tabid/69/forumid/10/postid/709/view/topic/Default.aspx

Note, DicomDirectoryWriter.cs is a new file but I did not include the .csproj in the patch, as mine is different (I don't include Offis or other things).  So, please add to your .csproj file.

I changed the name of DirectoryRecord to DirectoryRecordSequenceItem and put it in DicomSequenceItem.cs.

A few other additions:
1. In DicomAttributeBinary.cs in a few of the classes (DicomAttributeUS) I updated the Values property to check for more types of the value.

2.  I added an  Object.GetHashCode()  to  fix warnings for: overrides Object.Equals(object o) but does not override Object.GetHashCode()  
ClearCanvas.Dicom.PixelSpacing
ClearCanvas.Dicom.PatientID
ClearCanvas.Dicom.PersonName
ClearCanvas.Dicom.PixelAspectRatio
ClearCanvas.Dicom.Window

3. Fixed warnings for not using variable e in catch (Exception e) in DicomAttribute.cs

Regards,

Dan


Attachment: 071123_DicomDirWriter+More.patch

steve
Senior Member
Senior Member
Posts:1932

--
2007-11-29 06:05 PM  
Dan,

Thanks for the contribution! Sorry for the delay on this, I just got back from RSNA today.

I did make some mainly cosmetic changes to the code. I did change some references to Platform.Log to use the DicomLogger.Log..() routines instead. This is mainly in anticipation of us eventually removing the dependency on ClearCanvas.Common from the assembly.

Resharper also recommended some changes in some of the code, including changing some of the private methods in the class to static. I've gone ahead and done that. This caused me to have to rearrange the methods to match the regions set in the source file.

I think there could be some more polishing to insert more tags into the DICOMDIR, and perhaps to insert into the DICOMDIR right away when a file is added, instead of waiting until Save() is called. Also, some of the other non-IMAGE directory records should be supported below the Series level. We can expand and clean this up at some point in the future. Otherwise, it looks great, and thanks for the contribution.

Steve


Real-time support available to Clinical Edition and Team Edition customers
You are not authorized to post a reply.

Active Forums 4.1
Copyright 2012 ClearCanvas Inc.